-
Couldn't load subscription status.
- Fork 78
fix(FR-1501): fix file upload status tracking and error handling #4412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.65% (-0.01% 🔻) |
532/11445 |
| 🔴 | Branches | 3.75% (-0.01% 🔻) |
302/8056 |
| 🔴 | Functions | 2.88% (-0% 🔻) |
102/3547 |
| 🔴 | Lines | 4.6% (-0.01% 🔻) |
514/11186 |
Test suite run success
121 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 8a3b9bd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Fixes inaccurate and fragile file upload status tracking by restructuring status data and improving progress calculation and notifications.
- Introduces structured UploadStatus objects with vFolderNames and totalSize.
- Adds byte-based progress and concurrent uploads (PQueue concurrency 10).
- Adjusts FolderExplorer to new status shape.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| react/src/components/FolderExplorer.tsx | Updated empty-pending check to match new nested status structure. |
| react/src/components/FileUploadManager.tsx | Refactored data structures, progress computation, notification messaging, and concurrency. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
d5cfaff to
3f7e879
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please apply copilot's reviews and resolve conflicts
bbb4912 to
c4f7e84
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
c4f7e84 to
8a3b9bd
Compare

Resolves #4316 (FR-1501)
Changes
Fixes file upload status tracking and progress calculation issues, particularly for concurrent uploads. Refactored the upload state management to properly track upload progress using bytes instead of just file counts.
Key Changes
Enhanced State Management Structure
Fixed Progress Calculation
Testing
is in progress)
Technical Details
The main issue was that the original implementation only tracked file names without considering actual bytes uploaded. This led to inaccurate progress reporting, especially for files of varying sizes. The new implementation:
Checklist: